Skip to content

Footer enhancement : Solved Issue #767 #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codeaashu merged 5 commits into from
Jan 27, 2025
Merged

Footer enhancement : Solved Issue #767 #768

codeaashu merged 5 commits into from
Jan 27, 2025

Conversation

@revanthkumarJ
Copy link
Contributor

@revanthkumarJ revanthkumarJ commented Jan 20, 2025 •
edited
Loading

Description

Chnaged Footer code so that icons are visible now and updated their links to current DevDisplay links.
Removed Rebundant code
Used Footer code repetitively where ever it is needed instead of calling Footer component

Related Issues

#767

Changes Proposed

Checklist

  • I have read and followed the Contribution Guidelines.
  • All new and existing tests passed.
  • I have updated the documentation to reflect the changes I've made.
  • My code follows the code style of this project.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Before:
Screenshot 2025-01-20 093735
Now:
Screenshot 2025-01-20 100050

Note to reviewers

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Jan 20, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Jan 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devdisplay ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 4:50am

@revanthkumarJ revanthkumarJ mentioned this pull request Jan 20, 2025
Closed
1 task
@codeaashu codeaashu self-requested a review January 27, 2025 12:12
@codeaashu codeaashu added DevDisplay 🌟 This label recognizes every contributor to the DevDisplay Community for their support...💌 Dev Enhancer 🌟 Label 2 for second-time contributors who enhancing and refining features of DevDisplay. 🔧 Dev Innovator 🌟 Label 3 for contributors adding new, innovative features to DevDisplay, leading in creativity.💡 SWOC Label is used for accept the pull request of contributer in SWOC 2025 swoc25 Label is used for accept the pull request of contributer in SWOC 2025 labels Jan 27, 2025
@codeaashu codeaashu merged commit e7ebd3d into codeaashu:main Jan 27, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codeaashu codeaashu Awaiting requested review from codeaashu

Assignees

@revanthkumarJ revanthkumarJ

Labels

Dev Enhancer 🌟 Label 2 for second-time contributors who enhancing and refining features of DevDisplay. 🔧 Dev Innovator 🌟 Label 3 for contributors adding new, innovative features to DevDisplay, leading in creativity.💡 DevDisplay 🌟 This label recognizes every contributor to the DevDisplay Community for their support...💌 SWOC Label is used for accept the pull request of contributer in SWOC 2025 swoc25 Label is used for accept the pull request of contributer in SWOC 2025

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@revanthkumarJ @codeaashu