Merged
Conversation
|
can you an alias an output? i this breaking is going to cause us problems, I'd rather just point the old to the new. |
Author
|
@alanag13 You were right, this is what they want. |
added 2 commits
June 29, 2020 22:00
antazoey
commented
Jun 30, 2020
| file_results = CommandResults( | ||
| outputs_prefix="File", outputs_key_field=None, outputs=file_context | ||
| ) | ||
| return code42_results, file_results |
Author
There was a problem hiding this comment.
@kiran-chaudhary The way it is set up, these commands are allowed to return 1 or more CommandResults objects. This command is the only one that returns more than one. The reason for this is because they have different outputs_prefix properties, which is important when digging through Incident Context looking at the Outputs - and mapping outputs to different things, etc. Our integration modifies the system "File" outputs (line 744) as well as our own custom-defined Code42 outputs.
added 2 commits
June 30, 2020 13:04
alanag13
approved these changes
Jun 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the new way we are supposed to return stuff from Commands. The old way is deprecated and I was asked to change it. There are no changes in usage.
Also squeezes in some missing changelog entries (the only breaking changes). Which by the way could cause problems for us.