Skip to content

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Jun 15, 2024

This PR is part of #695

It includes:

  • set and forward logLevel in plugin-lighthouse runner
  • set lighthouse CLI flag quiet to true by default (hide logs by default)
  • adopt and rename setLoglevel function
  • extend unit-tests
  • use new implementation to display logs in the CI

closes #710

@github-actions
Copy link
Contributor

Code PushUp

🥳 Code PushUp report has improved – compared target commit 773012f with source commit 0a8ed63.

🏷️ Categories

🏷️ Category ⭐ Current score ⭐ Previous score 🔄 Score change
Performance 🟢 91 🟡 88 ↑ +3.1
Code coverage 🟡 89 🟡 89 ↑ +0
Accessibility 🟢 98 🟢 98
Best Practices 🟢 100 🟢 100
SEO 🟡 85 🟡 85
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
Security 🟢 100 🟢 100
Updates 🟡 79 🟡 79
Custom checks 🟡 67 🟡 67

🗃️ Groups

👍 2 groups improved
🔌 Plugin 🗃️ Group ⭐ Current score ⭐ Previous score 🔄 Score change
Lighthouse Performance 🟢 91 🟡 88 ↑ +3.1
Code coverage Code coverage metrics 🟡 89 🟡 89 ↑ +0

18 other groups are unchanged.

🛡️ Audits

👍 7 audits improved, 11 audits changed without impacting score
🔌 Plugin 🛡️ Audit 📏 Current value 📏 Previous value 🔄 Value change
Lighthouse Max Potential First Input Delay 🟩 70 ms 🟥 270 ms ↓ −72 %
Lighthouse Minimizes main-thread work 🟨 2.5 s 🟥 3.1 s ↓ −18 %
Lighthouse Total Blocking Time 🟩 10 ms 🟩 180 ms ↓ −96 %
Lighthouse First Contentful Paint 🟩 1.1 s 🟩 1.3 s ↓ −11 %
Lighthouse Cumulative Layout Shift 🟨 0.147 🟨 0.148  −∞ %
Code coverage Branch coverage 🟨 83 % 🟨 83 %  +0 %
Code coverage Line coverage 🟩 91 % 🟩 91 %  +0 %
Lighthouse Time to Interactive 🟩 1.2 s 🟩 1.8 s ↓ −33 %
Lighthouse Metrics 🟩 1187 🟩 1779 ↓ −33 %
Lighthouse Speed Index 🟩 1.1 s 🟩 1.4 s ↓ −17 %
Lighthouse First Meaningful Paint 🟩 1.1 s 🟩 1.3 s ↓ −11 %
Lighthouse JavaScript execution time 🟩 0.1 s 🟩 0.1 s ↓ −36 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 432 KiB 🟩 Total size was 432 KiB ↓ +0 %
Lighthouse Largest Contentful Paint 🟨 2.6 s 🟨 2.6 s ↑ +0 %
Lighthouse Initial server response time was short 🟩 Root document took 10 ms 🟩 Root document took 0 ms ↑ +133 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 0 ms ↑ +200 %
Lighthouse Uses efficient cache policy on static assets 🟨 11 resources found 🟨 11 resources found ↓ +0 %
Lighthouse Server Backend Latencies 🟩 10 ms 🟩 10 ms ↓ −8 %

491 other audits are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review June 15, 2024 14:41
@BioPhoton BioPhoton requested a review from Tlacenka June 15, 2024 14:42
@BioPhoton BioPhoton merged commit 120b316 into main Jun 19, 2024
@BioPhoton BioPhoton deleted the log-plugin-process-internaly branch June 19, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(plugin-lighthouse): add logLevel to lighthouse flags

3 participants