Skip to content

Conversation

@poltorak
Copy link
Collaborator

@poltorak poltorak commented Jan 9, 2026

Covers #1168

Standardize Folder Naming

Scope: Renamed mockmocks folders for consistency
Files affected: 8 files across examples and nx-plugin packages
Impact: Pure renaming with corresponding import path updates

Files changed:

examples/plugins/src/lighthouse/mock/mocks/
packages/nx-plugin/mock/mocks/
Updated import references in test files and documentation

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 nx-plugin 🛠️ tooling labels Jan 9, 2026
@nx-cloud
Copy link

nx-cloud bot commented Jan 9, 2026

View your CI Pipeline Execution ↗ for commit bbd1d10

Command Status Duration Result
nx affected -t int-test --parallel=3 ✅ Succeeded 1m 17s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-20 16:54:35 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 9, 2026

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1209

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1209

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1209

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1209

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1209

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1209

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1209

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1209

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1209

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1209

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1209

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1209

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1209

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1209

commit: bbd1d10

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 194888a with previous commit d3230f1.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 36 🔴 36 ↓ −0.8
Code coverage 🟢 92 🟢 92 ↓ −0.1
Bug prevention 🟡 75 🟡 75 ↓ −0.1
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Code style 🟢 100 🟢 100
Security 🟡 51 🟡 51
Updates 🟡 78 🟡 78
Type Safety 🟡 67 🟡 67
Miscellaneous 🟡 67 🟡 67
Documentation 🔴 42 🔴 42
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👎 2 groups regressed, 👍 2 audits improved, 👎 3 audits regressed, 15 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 36 🔴 36 ↓ −0.8
Code coverage Code coverage metrics 🟢 92 🟢 92 ↓ −0.1

32 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 600 ms 🟩 Root document took 500 ms ↓ −16.5 %
Lighthouse Speed Index 🟥 6.2 s 🟥 6.6 s ↑ +6.5 %
Lighthouse First Contentful Paint 🟥 3.0 s 🟥 3.1 s ↑ +2.4 %
Code coverage Line coverage 🟩 92.3 % 🟩 92.2 % ↓ −0.1 %
Code coverage Branch coverage 🟨 89 % 🟨 89 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,104 KiB 🟩 Total size was 2,105 KiB ↑ +0.1 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 226 KiB 🟥 Potential savings of 226 KiB ↓ −22.1 %
Lighthouse Server Backend Latencies 🟩 690 ms 🟩 890 ms ↑ +29.4 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 95 KiB 🟥 Potential savings of 95 KiB ↓ −33.3 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 83 KiB 🟥 Potential savings of 90 KiB ↓ −33.3 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↑ +0.1 %
Lighthouse JavaScript execution time 🟥 4.5 s 🟥 4.6 s ↑ +2.7 %
Lighthouse Largest Contentful Paint 🟥 11.5 s 🟥 11.3 s ↓ −1 %
Lighthouse Max Potential First Input Delay 🟥 990 ms 🟥 1,080 ms ↑ +9.5 %
Lighthouse Minimizes main-thread work 🟥 9.7 s 🟥 9.8 s ↑ +0.7 %
Lighthouse Time to Interactive 🟥 13.3 s 🟥 13.2 s ↓ −0.4 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −0.4 %
Lighthouse Total Blocking Time 🟥 2,080 ms 🟥 2,050 ms ↓ −1.4 %
Lighthouse Network Round Trip Times 🟩 0 ms 🟩 20 ms ↑ +337.5 %
Code coverage Function coverage 🟩 94.3 % 🟩 94.3 % ↓ −0.1 %

659 other audits are unchanged.

@poltorak poltorak force-pushed the refactor/cosmetic-cleanup-and-changes branch 2 times, most recently from 777ce08 to 4fb2ca7 Compare January 9, 2026 12:01
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 194888a with previous commit d3230f1.

💼 Project create-cli

😟 Code PushUp report has regressed.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 96 🟢 96 ↓ −0.2

5 other categories are unchanged.

👎 1 group regressed, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 96 🟢 96 ↓ −0.2

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟨 88.2 % 🟨 87.5 % ↓ −0.8 %

443 other audits are unchanged.

💼 Project nx-plugin

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 91 🟢 92 ↑ +0.2

5 other categories are unchanged.

👍 1 group improved, 👍 1 audit improved, 👎 2 audits regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 91 🟢 92 ↑ +0.2

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟨 80.8 % 🟨 81.7 % ↑ +1.1 %
Code coverage Line coverage 🟩 93.2 % 🟩 93 % ↓ −0.2 %
Code coverage Function coverage 🟩 96.4 % 🟩 96.3 % ↓ −0.1 %

445 other audits are unchanged.

💼 Project utils

😟 Code PushUp report has regressed.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🔴 45 🔴 45 ↓ −0.1

5 other categories are unchanged.

👎 1 group regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🔴 45 🔴 45 ↓ −0.1

14 other groups are unchanged.

🛡️ Audits

All of 444 audits are unchanged.

💼 Project plugin-lighthouse

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

All of 6 categories are unchanged.

1 audit changed without impacting score

🗃️ Groups

All of 15 groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟩 98.8 % 🟩 98.8 % ↓ −0.1 %

443 other audits are unchanged.


10 other projects are unchanged.

@poltorak poltorak force-pushed the refactor/cosmetic-cleanup-and-changes branch from 4fb2ca7 to cdb82a1 Compare January 9, 2026 12:37
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split mock folder renaming and setup script refactoring into 2 PR's pls.
I have some more comments on the test setup that would delay the mock renaming part.

Also i already renamed your PR to: "test: standardise mocks folder names" so I can add my feedback related to the renaming here.

@BioPhoton BioPhoton changed the title Refactor: cosmetic cleanup and changes test: standardise mocks folder names Jan 9, 2026
@poltorak poltorak force-pushed the refactor/cosmetic-cleanup-and-changes branch from cdb82a1 to ffbe58d Compare January 12, 2026 08:17
@poltorak
Copy link
Collaborator Author

Could you split mock folder renaming and setup script refactoring into 2 PR's pls. I have some more comments on the test setup that would delay the mock renaming part.

Done, current PR contains only mocks rename

@poltorak poltorak force-pushed the refactor/cosmetic-cleanup-and-changes branch from ffbe58d to 961e2d8 Compare January 12, 2026 08:25
@poltorak poltorak marked this pull request as ready for review January 12, 2026 08:33
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! I left a suggestion for improvement.

Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the update! This will be a really nice alignment!

One last thing we could do is categorise our file types. (Im not 100% sure about the additional work so feel free to skip it if not super quick.)
e.g. performance.mock.ts contains the MockPerformanceObserver class and perf-hooks.setup-file.ts has the vi.mock call that uses performance.mock.ts exports.

Then test-utils would countain only helper (*.mock.ts or just plain helper functions like setupTestFolder) and test-setup would use them inside *.setup-file.ts files and contain the vi.mock, beforeEach etc.

@BioPhoton BioPhoton changed the title test: standardise mocks folder names test: standardise mock and setup file and testing related folder names Jan 14, 2026
@poltorak poltorak force-pushed the refactor/cosmetic-cleanup-and-changes branch from fa7b6bb to bbd1d10 Compare January 20, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧩 nx-plugin 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🛠️ tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants