Support server groups in workload spawner#560
Merged
PhilippMatthes merged 2 commits intomainfrom Mar 16, 2026
Merged
Conversation
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe changes add server group selection and management functionality to the spawner CLI. A new types package introduces a ServerGroup struct. CLI methods enable selection of server groups and policies. The main application now discovers, optionally deletes, creates server groups, and integrates them with VM spawning via scheduler hints. Changes
Sequence Diagram(s)sequenceDiagram
participant User as User
participant CLI as Spawner CLI
participant API as OpenStack API
participant ServerCreate as Server Creation
User->>CLI: Run spawner
CLI->>API: List server groups (os-server-groups)
API-->>CLI: Existing groups
alt Groups found with matching prefix
CLI->>User: Prompt to delete existing groups
User-->>CLI: Confirm deletion
CLI->>API: Delete groups (concurrent)
API-->>CLI: Deletion complete
end
CLI->>API: Re-fetch server groups
API-->>CLI: Updated groups list
alt User opts to create new group
CLI->>User: Prompt for server group policy
User-->>CLI: Select policy
CLI->>API: Create new server group (POST os-server-groups)
API-->>CLI: New group ID
CLI->>CLI: Track selectedServerGroupID
end
CLI->>User: Proceed to server creation
User-->>CLI: Confirm VM spawn
CLI->>ServerCreate: Pass selectedServerGroupID via SchedulerHintOpts.Group
ServerCreate->>API: Create servers with group affinity
API-->>ServerCreate: Servers created
ServerCreate-->>CLI: Creation complete
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip You can make CodeRabbit's review stricter and more nitpicky using the `assertive` profile, if that's what you prefer.Change the |
Member
Author
|
I will merge this without a review since it is only development tooling. |
Contributor
Test Coverage ReportTest Coverage 📊: 67.9% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support server groups in the workload spawner, so we can spawn vms with anti-affinity or affinity rules.
Summary by CodeRabbit