Skip to content

Add Server::listen() method instead of accepting socket in constructor#80

Merged
clue merged 1 commit intoclue:masterfrom
clue-labs:listen
Nov 13, 2018
Merged

Add Server::listen() method instead of accepting socket in constructor#80
clue merged 1 commit intoclue:masterfrom
clue-labs:listen

Conversation

@clue
Copy link
Owner

@clue clue commented Nov 13, 2018

// old
$socket = new React\Socket\Server(1080, $loop);
$server = new Clue\React\Socks\Server($loop, $socket);

// new
$server = new Clue\React\Socks\Server($loop);
$socket = new React\Socket\Server(1080, $loop);
$server->listen($socket);

@clue clue added this to the v1.0.0 milestone Nov 13, 2018
@clue clue merged commit c7c7ba0 into clue:master Nov 13, 2018
@clue clue deleted the listen branch November 13, 2018 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant