Added example for connecting to unix socket#68
Closed
cebe wants to merge 1 commit intoclue:masterfrom
Closed
Conversation
Owner
|
Good catch, thank you for this contribution! The code LGTM, but it makes me wonder if it makes more sense to just integrate this into this library. I was actually planning to integrate this somewhat similar to clue/reactphp-socks#69 and possibly use the What do you think about this? 👍 |
Author
|
of course it would make sense to add direct support for it but there are a few things that are unclear about how to handle it:
|
Author
|
Btw, I really like how much documentation is added for all the react libraries, thanks for that! :) |
Owner
|
Thank you for sparking this discussion and for your positive feedback, this has just been resolved via #70! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was searching for a way to connect to redis via unix socket and I found it a bit too hard to find, so I added this here.