Move from private to protected for extensibility#25
Move from private to protected for extensibility#25jom wants to merge 1 commit intoclue:masterfrom jom:make-extensible
Conversation
|
Thanks for filing this PR! I can see where you're coming from, but IMO making this protected is a bad choice for multiple reasons:
I'm really curious to see what you're up to, perhaps pushing these "extensions" upstream into this library can help finding some better extension points? 👍 Feel invited to share your finding and I'm happy to review things! :-) |
|
I've added a containerStats and containerLogs. I don't have tests for them yet, but can push them up, at least... I just don't like being slowed down ;) |
Thanks for filing this in #26, I very much appreciate any suggestions, even if they're still WIP 👍
I agree that this process should not slow you down at all :-) File your suggestions as PRs and I'll look at these as soon as time permits. In the meantime, you can still build on top of your private fork |
I'd like to extend this in my libraries. If useful and once tested, I'll add what I extend back into the library. Any harm in making things protected instead of private?