Use HTTP/1.1 protocol version by default and add new Browser::withProtocolVersion()#162
Merged
clue merged 2 commits intoclue:masterfrom May 7, 2020
Merged
Use HTTP/1.1 protocol version by default and add new Browser::withProtocolVersion()#162clue merged 2 commits intoclue:masterfrom
Browser::withProtocolVersion()#162clue merged 2 commits intoclue:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset introduces HTTP/1.1 protocol version as the new default and adds a new
Browser::withProtocolVersion()method to change this behavior. This is the preferred HTTP protocol version which also provides decent backwards-compatibility with legacy HTTP/1.0 servers. As such, there should rarely be a need to explicitly change this protocol version. Accordingly, this is not considered to be a BC break.By default, all of the request methods default to sending requests using the
HTTP/1.1 protocol version. If you want to explicitly use the legacy HTTP/1.0
protocol version, you can use the
withProtocolVersion()method. If you want to use any other or even custom HTTP request method, you can
use the
send()method.Resolves #137
Refs #154
Builds on top of #161, #97, #58 and others
Also done in preparation for #49 and #89