Improve error reporting by appending previous message for Throwables#57
Merged
SimonFrings merged 1 commit intoclue:masterfrom Oct 17, 2021
Merged
Improve error reporting by appending previous message for Throwables#57SimonFrings merged 1 commit intoclue:masterfrom
Throwables#57SimonFrings merged 1 commit intoclue:masterfrom
Conversation
SimonFrings
approved these changes
Oct 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset improves error reporting by appending previous exception messages for
Throwables (PHP 7+). This improves DX by making it easier to see the underlying error causes without having to check the previous exception via$e->getPrevious().Ideally, this would just throw the
Throwablewithout wrapping this in anUnexpectedValueException, but this would constitute a BC break. Appending the original type and message to theUnexpectedValueExceptionat least makes it more obvious to see the underlying error condition without introducing a BC break.Supersedes / closes #52
Supersedes / closes #56
Builds on top of #7/#27/#42
Refs reactphp/promise-stream#26, friends-of-reactphp/mysql#141 and others