Fix is_object() check on rejections with truthy non-Exception values#40
Closed
esroyo wants to merge 1 commit intoclue:masterfrom
esroyo:master
Closed
Fix is_object() check on rejections with truthy non-Exception values#40esroyo wants to merge 1 commit intoclue:masterfrom esroyo:master
esroyo wants to merge 1 commit intoclue:masterfrom
esroyo:master
Conversation
Owner
Author
|
Thanks to you @clue 😺 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
React\Promise\some()returns an array of Exceptions as the resolved value, thenBlock\awaitfails on that promise. Turns out this bug bypassed all tests because$exceptionwas always tested with falsy values, so($exception) ? get_class($exception) : gettype($exception)was passing anyway. But when$exceptionis a non empty array (of Exceptions), this bug emerges.