Draft
Conversation
acdf34d to
7e47d92
Compare
e050951 to
36ee9cb
Compare
Base automatically changed from
kanstantsinbuklis-sap/issue-1070/remove-evidence
to
main
February 17, 2026 10:23
b9679e4 to
6a1410d
Compare
6a1410d to
8549846
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a CI mechanism to run a “migration up/down” smoke test only when MariaDB migration files change, to keep PR test runs fast while still validating schema migrations when relevant.
Changes:
- Add Makefile targets to detect migration changes and run an up/down migration test against a dedicated schema.
- Update CI workflow to fetch base ref, detect migration changes, and conditionally run the migration test.
- Refactor
create-migrationto use the sharedMIGRATIONS_DIRvariable.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| Makefile | Adds migration detection/testing targets and updates migration file checks. |
| .github/workflows/tests.yaml | Conditionally installs migration tooling and runs the migration test when migrations change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d2369a0 to
4cc23a7
Compare
30d3dd7 to
45ed1b5
Compare
ed2dc3c to
9ffc2d2
Compare
On-behalf-of: SAP Michal Krzyz <michal.krzyz@sap.com> Signed-off-by: Michal Krzyz <michalkrzyz@gmail.com>
9ffc2d2 to
d6f6ed4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we want to have this kind of test in testrun we would need to consider:
On-behalf-of: SAP Michal Krzyz michal.krzyz@sap.com
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist