Upgrade JUnit4 to JUnit5#1207
Merged
pivotal-david-osullivan merged 2 commits intocloudfoundry:mainfrom Feb 6, 2024
Merged
Conversation
anthonydahanne
approved these changes
Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to complete this upgrade, I followed public documentation, here:
I employed OpenRewrite to perform initial bulk operation with:
I also upgraded dependencies and plugins in root
pom.xml:Afterwards:
AbstractRestTest.java, then replaced a reference toorg.junit.ComparisonFailure(no longer available in JUnit5) which was itself is a subclass ofjava.lang.AssertionError.DefaultApplicationsTest.java,DefaultSpacesTest.javawhereSupplier<T>anonymous impl forget()method did not have correct visibility.Result: