Skip to content

Conversation

@philippthun
Copy link
Contributor

The _is_token_expired method does not detect CF-InvalidAuthToken errors returned by V3 API endpoints.

Also see error object in V3 API documentation.

@antechrestos antechrestos merged commit e602482 into cloudfoundry-community:master Apr 17, 2020
@antechrestos
Copy link
Member

@philippthun thank you for your contribution

I will make a proper release in the next few days.

@antechrestos
Copy link
Member

Released in 1.12.5

@alinagol
Copy link

Hey,

I see the same issue in v1.14.1.
Screenshot 2020-10-30 at 10 11 32
Screenshot 2020-10-30 at 10 11 43

@antechrestos
Copy link
Member

@alinagol correct me if I am wrong
You are using v1.14.1 yet you see a ambigous behaviour: it logs you your token is not expired (hence does not refresh it ), yet the error is a v3 token expired.

Yet I have a question: in the 1.14.1 code, the log is either _is_token_v3_expired or _is_token__v2_expired). Is it possible you have two version installed? Or you overwrote the method _is_token_expired?

@alinagol
Copy link

Hey,
Sorry for the late reply, I absolutely forgot to follow up.
You were right, the forked version that I use is 1.12.4. Sorry for the confusion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants