Skip to content

fix: e2e tests fail due to premature timeouts#375

Merged
xtuc merged 1 commit into
cloudflare:mainfrom
Distal-Labs:fix-playwright-timeouts
Mar 7, 2023
Merged

fix: e2e tests fail due to premature timeouts#375
xtuc merged 1 commit into
cloudflare:mainfrom
Distal-Labs:fix-playwright-timeouts

Conversation

@DataDrivenMD
Copy link
Copy Markdown
Contributor

@DataDrivenMD DataDrivenMD commented Mar 7, 2023

  • Fixes timeouts so that tests don't fail on Github Actions runners
  • Lowers number of retries so that e2e tests don't run for 2+ hours before giving up

- [X} Fixes timeouts so that tests don't fail on Github Actions runners
- [X] Lowers number of retries so that e2e tests don't run for 2+ hours before giving up
@DataDrivenMD DataDrivenMD mentioned this pull request Mar 7, 2023
3 tasks
@xtuc xtuc requested a review from dario-piotrowicz March 7, 2023 08:00
Copy link
Copy Markdown
Contributor

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, I'm not fan of different behaviors between CI and local, but let's merge for now.

@xtuc xtuc merged commit f1b9fcd into cloudflare:main Mar 7, 2023
@xtuc xtuc deleted the fix-playwright-timeouts branch March 7, 2023 08:01
@dario-piotrowicz
Copy link
Copy Markdown
Member

For the record, I'm not fan of different behaviors between CI and local, but let's merge for now.
to be fair I added the different behaviour a while back because it was getting annoyed waiting unnecessarily long locally to see a test fail 😅

@DataDrivenMD
Copy link
Copy Markdown
Contributor Author

For the record, I'm not fan of different behaviors between CI and local, but let's merge for now.
to be fair I added the different behaviour a while back because it was getting annoyed waiting unnecessarily long locally to see a test fail 😅

I agree, and thank you for making the exception. It was driving me nuts that code would seem to work locally, and then randomly fail during PR checks. I tried a few iterations that relied on just configuration for all environments, but local e2e testing with a single worker is painful to watch lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants