Skip to content

[Logs] Update Logpush Enable BigQuery page#29571

Open
soheiokamoto wants to merge 1 commit intoproductionfrom
sohei/DS-16241-update-logpush-setup-bq-destination
Open

[Logs] Update Logpush Enable BigQuery page#29571
soheiokamoto wants to merge 1 commit intoproductionfrom
sohei/DS-16241-update-logpush-setup-bq-destination

Conversation

@soheiokamoto
Copy link
Copy Markdown
Contributor

Summary

This updates Logpush Enable BigQuery page.

Changelog file is added.

Documentation checklist

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/changelog/ @cloudflare/pm-changelogs, @cloudflare/pcx-technical-writing
/src/content/docs/logs/ @soheiokamoto, @angelampcosta, @rianvdm, @cloudflare/pcx-technical-writing

@soheiokamoto
Copy link
Copy Markdown
Contributor Author

/bonk review this changelog entry and recommend how it could be improved

Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found several issues that need to be addressed before merging:

---

Configure Logpush to send batches of Cloudflare logs to BigQuery.
import { Render } from "~/components";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

component is used but not imported:

Suggested change
import { Render } from "~/components";
import { Render, APIRequest } from "~/components";


## Create and get access to a BigQuery table

Cloudflare uses Google Application Credentials provided in Logpush job `destination_conf` to gain write access to your bucket. The provided service account needs a write permission for the bucket.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BigQuery uses tables, not buckets:

Suggested change
Cloudflare uses Google Application Credentials provided in Logpush job `destination_conf` to gain write access to your bucket. The provided service account needs a write permission for the bucket.
Cloudflare uses Google Application Credentials provided in Logpush job `destination_conf` to gain write access to your table. The provided service account needs a write permission for the table.

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Apr 3, 2026

I've posted a review on PR #29571 with 7 inline suggestions addressing the following issues:

Summary

CRITICAL / HIGH issues that need fixing:

  1. Missing import (line 11): APIRequest component is used but not imported
  2. Wrong terminology (line 17): "bucket" should be "table" for BigQuery
  3. Copy-paste error (lines 51-53): Note incorrectly references "SentinelOne" instead of "BigQuery"
  4. Typo (line 65): "bassh" should be "bash"
  5. Typos (line 71): "optopns" → "options", "BiqQuery" → "BigQuery"
  6. JSON syntax error (lines 79-81): Duplicate "destination_conf" key with incorrect formatting
  7. Copy-paste error (lines 174-175): "Datadog" mentioned instead of BigQuery limits

Changelog entry looks good and follows the correct format.

All issues can be addressed by accepting the inline suggestions in the PR review.

github run

@soheiokamoto soheiokamoto force-pushed the sohei/DS-16241-update-logpush-setup-bq-destination branch from 36c0fba to b11cdb2 Compare April 3, 2026 02:33
This updates Logpush Enable BigQuery page.

Changelog file is added.
@soheiokamoto soheiokamoto force-pushed the sohei/DS-16241-update-logpush-setup-bq-destination branch from b11cdb2 to 4d32a19 Compare April 3, 2026 02:35
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

CI run failed: build logs

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Apr 3, 2026

The type check passed with 0 errors.

Looking at the current state of the PR, all the issues previously identified by ask-bonk have been addressed:

✅ All Issues Fixed

Issue Status
Missing APIRequest import Fixed - Line 11 correctly imports APIRequest
Wrong terminology "bucket" Fixed - Line 17 correctly uses "table"
Copy-paste error referencing SentinelOne Fixed - Lines 51-53 correctly reference BigQuery
Typo bassh Fixed - Line 65 correctly uses bash
Typos "optopns" / "BiqQuery" Fixed - Line 71 correctly uses "options" / "BigQuery"
JSON syntax error Fixed - Lines 79-81 have proper JSON structure
Datadog reference instead of BigQuery Fixed - Lines 174-175 correctly reference BigQuery

Changelog entry (src/content/changelog/logs/2026-04-02-bigquery-destination.mdx) follows the correct format with proper frontmatter.

No issues found - the PR is ready for merge.

github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants