[Logs] Update Logpush Enable BigQuery page#29571
[Logs] Update Logpush Enable BigQuery page#29571soheiokamoto wants to merge 1 commit intoproductionfrom
Conversation
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
|
/bonk review this changelog entry and recommend how it could be improved |
| --- | ||
|
|
||
| Configure Logpush to send batches of Cloudflare logs to BigQuery. | ||
| import { Render } from "~/components"; |
There was a problem hiding this comment.
component is used but not imported:
| import { Render } from "~/components"; | |
| import { Render, APIRequest } from "~/components"; |
|
|
||
| ## Create and get access to a BigQuery table | ||
|
|
||
| Cloudflare uses Google Application Credentials provided in Logpush job `destination_conf` to gain write access to your bucket. The provided service account needs a write permission for the bucket. |
There was a problem hiding this comment.
BigQuery uses tables, not buckets:
| Cloudflare uses Google Application Credentials provided in Logpush job `destination_conf` to gain write access to your bucket. The provided service account needs a write permission for the bucket. | |
| Cloudflare uses Google Application Credentials provided in Logpush job `destination_conf` to gain write access to your table. The provided service account needs a write permission for the table. |
src/content/docs/logs/logpush/logpush-job/enable-destinations/bigquery.mdx
Show resolved
Hide resolved
src/content/docs/logs/logpush/logpush-job/enable-destinations/bigquery.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/logs/logpush/logpush-job/enable-destinations/bigquery.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/logs/logpush/logpush-job/enable-destinations/bigquery.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/logs/logpush/logpush-job/enable-destinations/bigquery.mdx
Outdated
Show resolved
Hide resolved
|
I've posted a review on PR #29571 with 7 inline suggestions addressing the following issues: SummaryCRITICAL / HIGH issues that need fixing:
Changelog entry looks good and follows the correct format. All issues can be addressed by accepting the inline suggestions in the PR review. |
36c0fba to
b11cdb2
Compare
This updates Logpush Enable BigQuery page. Changelog file is added.
b11cdb2 to
4d32a19
Compare
|
CI run failed: build logs |
|
The type check passed with 0 errors. Looking at the current state of the PR, all the issues previously identified by ask-bonk have been addressed: ✅ All Issues Fixed
Changelog entry ( No issues found - the PR is ready for merge. |
Summary
This updates Logpush Enable BigQuery page.
Changelog file is added.
Documentation checklist