removed events_listener; added basic test for webhooks_listener#348
Merged
removed events_listener; added basic test for webhooks_listener#348
Conversation
andrey18106
approved these changes
Apr 14, 2025
Signed-off-by: bigcat88 <bigcat88@icloud.com>
7483d55 to
2d70877
Compare
Signed-off-by: bigcat88 <bigcat88@icloud.com>
2d70877 to
06e4f59
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
+ Coverage 94.52% 95.13% +0.61%
==========================================
Files 46 45 -1
Lines 5389 5325 -64
==========================================
- Hits 5094 5066 -28
+ Misses 295 259 -36
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with Nextcloud 30 there is a
webhooks_listenerapp that is enabled by default and supports both regular requests and requests from ExApps!It has much more and better functionality than
events_listenerin AppAPI, and we will removeevents_listenerfor Nextcloud 32 from AppAPI.In this PR I am removing
events_listenerand reworking the tests forevents_listenerinto basic tests forwebhooks_listener.