feat(clerk-js): Include current search params in handleRedirectCallback
#7600
+61
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that component
AuthenticateWithRedirectCallbackautomatically incorporates any redirects in the current query to match the documented usagePart of USER-4308
Without a fix like this the developer must manually snag and specify all the possible redirects, which I think is not the intent of the component.
Note to Reviewers
Is this the best place to insert the URL's query params? It could be done at a higher level, e.g. adding an argument to
handleRedirectCallback. Are there scenarios where it is undesirable to automatically use the window's current query?What are some scenarios I should manually test?
It would be helpful to consider this change in conjunction with this docs change.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change