-
Notifications
You must be signed in to change notification settings - Fork 424
[WIP] feat(clerk-js): Improve getToken offline handling
#7598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bratsos
wants to merge
11
commits into
main
Choose a base branch
from
alexbratsos/user-4063-improve-gettoken-offline-handling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5a25c7b
feat(repo): Add a library-agnostic `getToken` helper
bratsos 5b505e0
fixup! feat(repo): Add a library-agnostic `getToken` helper
bratsos faa2630
fixup! feat(repo): Add a library-agnostic `getToken` helper
bratsos fc8f922
fixup! feat(repo): Add a library-agnostic `getToken` helper
bratsos 81be559
fixup! feat(repo): Add a library-agnostic `getToken` helper
bratsos dd26063
chore: add changeset
bratsos d682756
fixup! feat(repo): Add a library-agnostic `getToken` helper
bratsos 7ea2a1a
fixup! feat(repo): Add a library-agnostic `getToken` helper
bratsos cb48bea
fixup! feat(repo): Add a library-agnostic `getToken` helper
bratsos 258ac03
fixup! feat(repo): Add a library-agnostic `getToken` helper
bratsos b6350c6
wip
bratsos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| --- | ||
| '@clerk/tanstack-react-start': minor | ||
| '@clerk/react-router': minor | ||
| '@clerk/clerk-js': minor | ||
| '@clerk/nextjs': minor | ||
| '@clerk/shared': minor | ||
| '@clerk/astro': minor | ||
| '@clerk/react': minor | ||
| '@clerk/nuxt': minor | ||
| '@clerk/vue': minor | ||
| --- | ||
|
|
||
| Add standalone `getToken()` function for retrieving session tokens outside of framework component trees. | ||
|
|
||
| This function is safe to call from anywhere in the browser, such as API interceptors, data fetching layers (e.g., React Query, SWR), or vanilla JavaScript code. It automatically waits for Clerk to initialize before returning the token. | ||
|
|
||
| import { getToken } from '@clerk/nextjs'; // or any framework package | ||
|
|
||
| // Example: Axios interceptor | ||
| axios.interceptors.request.use(async (config) => { | ||
| const token = await getToken(); | ||
| if (token) { | ||
| config.headers.Authorization = `Bearer ${token}`; | ||
| } | ||
| return config; | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| export { updateClerkOptions } from '../internal/create-clerk-instance'; | ||
| export * from '../stores/external'; | ||
| export { getToken } from '@clerk/shared/getToken'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something we want to happen for all resources, or just the session resource?