Skip to content

fix(clerk-js): Variable line-height discrepancy #7112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcarpenter merged 4 commits into from
Dec 1, 2025
Merged

fix(clerk-js): Variable line-height discrepancy #7112

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b3831d5
fix(clerk-js): Variable line-height discrepancy
alexcarpenter Oct 31, 2025
45f5c10
add changeset
alexcarpenter Oct 31, 2025
7bcea15
Merge branch 'main' into alexcarpenter/fix-line-height-discrepency
alexcarpenter Nov 18, 2025
bdfb372
add changeset
alexcarpenter Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/twenty-sides-take.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Updates line-height calculations to follow font-sizing to fix differences across browsers.
18 changes: 9 additions & 9 deletions packages/clerk-js/src/ui/foundations/typography.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,22 @@ const fontWeights = Object.freeze({

const lineHeights = Object.freeze({
normal: 'normal',
extraSmall: '1.33333',
small: '1.38462',
medium: '1.41176',
large: '1.45455',
extraSmall: '16 / 12', // = 1.33333
small: '18 / 13', // = 1.38462
medium: '24 / 17', // = 1.41176
large: '16 / 11', // = 1.45455
Comment thread
alexcarpenter marked this conversation as resolved.
} as const);

const letterSpacings = Object.freeze({
normal: 'normal',
} as const);

export const FONT_SIZE_SCALE_RATIOS = Object.freeze({
xs: '11 / 13', // 0.846154
sm: '12 / 13', // 0.923077
md: '1', // 1.0
lg: '17 / 13', // 1.307692
xl: '24 / 13', // 1.846154
xs: '11 / 13', // = 0.846154
sm: '12 / 13', // = 0.923077
md: '1', // = 1.0
lg: '17 / 13', // = 1.307692
xl: '24 / 13', // = 1.846154
} as const);

export type FontSizeKey = keyof typeof FONT_SIZE_SCALE_RATIOS;
Expand Down
Loading