Conversation
general - remove the redundant religion check - only check num_of_holy_sites for random world as previous block already checked piety - shia_caliphate_revolt_ongoing should only effects shia d_kharijite - only check piety d_qarmatian - add missing bloodline check - fix requirement for bloodline owners d_shiite - add missing bloodline check - fix requirement for bloodline owners d_yazidi - add can_create_duchy check
- move mecca_medina above jerusalem_damascus_baghdad for consistency - only display the piety option for sayyid - no sayyid bonus for kharijite - hide unused sayyid bonus for bloodline owners
schwarherz
approved these changes
Oct 21, 2023
Contributor
schwarherz
left a comment
There was a problem hiding this comment.
This looks ok to me. I'm a little unsure if it's in-scope but I'm going to merge it. If someone else thinks it's out of scope, feel free to roll back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
landed_titles: fix caliphate requirements
general
already checked piety
d_kharijite
d_qarmatian
d_shiite
d_yazidi
scripted_triggers: minor fix for tooltip
decisions: outremer should also destroy qarmatian
form_the_outremer