Merged
Conversation
- let AI consider family focus when they have living spouse - fix beloved target score value for spouse - allow to think of spouse in HFP.11001 (killed in battle) - use correct flag sway_hunting - fix option trigger in LT.20405 (use_secluded_upgrade target) - fix 100170 (my friend's friend is my friend) event target - fix 100411 (ask liege to allow duel with rival) combat not firing
form_teutonic_order - allow emperor of HRE to see the decision create_archduchy_of_austria - allow child to see the decision - fix requirement for d_salzburg d_tyrol prepare_coronation_ceremony - fix the trigger donate_money_to_knights_santiago donate_money_to_knights_calatrava - fix the culture check feast_0 - block the decision if already did it recently events - fix the possessed option in HF.120 (gain trait of bloodline founder) - do not send HF.24210 (notify other players of alexander bloodline) to yourself - fix trigger in HF.40090 (bad papal saint) - fix option trigger in 72008 (hunt boar for feast) - check is_pregnant against ROOT in 72076 (friendly with guest's spouse) - fix 72086 (claim on guest's title) - use is_capital for 39640 (rise of shi'a caliphate) - should lose zealous in 74040 (mages and divinators visits the fair) - do not set unused flag prepare_fallback_event - prevent invasion of empty target in JD.10100 - refresh business trade route modifier properly - update localisation key for secretly convert to aztec/bon
schwarherz
reviewed
Jul 12, 2023
Contributor
schwarherz
left a comment
There was a problem hiding this comment.
I need these comments addressed before I can approve this
hold_a_epic_tournament - remove unnecessary owns location check hold_a_furusiyya - add missing nomad check - remove unnecessary owns location check - remove redundent do_not_disturb check become_samrat_chakravartin - remove redundent independent check form_the_hre_early - add missing independent check
- remove duplicate ill effect - check the correct flag death_murder_poison - delay death to let the event chain completes
Contributor
Author
|
decision: hide the false secretly convert to bon secretly_convert_to_bon_pagan_holy_site
decision: fix some potential checking hold_a_epic_tournament
hold_a_furusiyya
become_samrat_chakravartin
form_the_hre_early
events: fix 100522 poison rival at feast
|
schwarherz
approved these changes
Oct 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decision
form_teutonic_order
create_archduchy_of_austria
prepare_coronation_ceremony
donate_money_to_knights_santiago
donate_money_to_knights_calatrava
feast_0
events
yourself
fix some friend rival events and family stuff