Bug: Include military time for semantic infer #250
Merged
+52
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
KristijanArmeni
requested changes
Nov 4, 2025
Collaborator
KristijanArmeni
left a comment
There was a problem hiding this comment.
This is wonderful, thank you for adding @JMCulhane! A minor comment in the codebase itself. And just two thoughts:
- Adding unit tests. Could we add a short unit test in
preprocessing/test_series_semantic.pythat will test this helper function? (see the example for timezone parsing helper.) - If this addresses only a subpart of #249, perhaps we can create sub-issue for just the military time handling which this PR addresses?
It's great to split it in small chunks otherwise. I think if we add tests, I'd merge this and can ship with v0.10.0. And we can address follow-ups separately.
KristijanArmeni
approved these changes
Nov 21, 2025
Collaborator
KristijanArmeni
left a comment
There was a problem hiding this comment.
Thanks for this @JMCulhane, looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Currently, the CLI has trouble recognizing 24 hour/military time format. Included in this PR is a new series_Semantic case along with a parsing function to handle flexible time formats.
What is the new behavior?
The time type will be recognized and parsed. This is a subissue (Issue 265) of Issue 249 and is the first step in updating the CLI so that it can handle separate columns.
Does this introduce a breaking change?