Relocate contents of Lighting tab; hide Cloud settings when Enable clouds is disabled#1494
Draft
Peregrine05 wants to merge 4 commits into
Draft
Relocate contents of Lighting tab; hide Cloud settings when Enable clouds is disabled#1494Peregrine05 wants to merge 4 commits into
Lighting tab; hide Cloud settings when Enable clouds is disabled#1494Peregrine05 wants to merge 4 commits into
Conversation
- Relocated cloud controls to a collapsible panel called `Cloud settings`. - Set the panel to be hidden if `Enable clouds` is disabled. - Updated some tooltips.
- Move `Sky exposure`, `Sky light intensity`, and `Apparent sky brightness` to the `Sky & Fog` tab. - Add an `Apparent sun size` control. - Add a `Sun` tab. - Move all sun controls to the `Sun` tab. - Rename the `Lighting` tab to the `Emitters` tab. - Add a hint about material emittance to the `Emitters` tab. - Move ESS controls from the `Advanced` tab to the `Emitters` tab. - Disable controls when their effects are nullified by the value of another control. - Relocated cloud controls to a collapsible panel called `Cloud settings`. - Set the panel to be hidden if `Enable clouds` is disabled. - Updated some tooltips. - Increase the wrapping width of the hint in the `Postprocessing` tab.
leMaik
requested changes
Dec 27, 2022
leMaik
approved these changes
Dec 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1476
Changes
Sky exposure,Sky light intensity, andApparent sky brightnessto the Sky & Fog tab.Apparent sun sizecontrol.Cloud settings.Enable cloudsis disabled.Cloud Yis "Changes the height of the clouds.").Disabling Controls
Sun tab:
Setting Sun Sampling Strategy:
to
OFFdisables:Sunlight Intensityto
NON_LUMINOUSdisables:Sunlight intensitySun luminositySun sizeSunlight colorto
FASTdisables:Sun luminositySun sizeto
HIGH_QUALITYdisables nothing.Disabling
Draw sundisables:Apparent sun brightnessApparent sun sizeModify sun texture by colorApparent sun colorSky & Fog tab:
Setting Sky mode to
BLACKdisables:Sky exposureSky light intensityApparent sky brightnessSetting
Fog densityto 0 disables:Sky-fog blendingEmitters tab:
Disabling
Enable emittersdisables:Emitter intensityEmitter Sampling StrategyEmitter grid sizePrevent normal emitter when using emitter samplingImages
Suntab:Sky & Fogtab:Emitterstab: