Skip to content
This repository was archived by the owner on Nov 9, 2017. It is now read-only.

libextra is deleted. extra::url has moved out to a separate library.#65

Merged
chris-morgan merged 1 commit intomasterfrom
unknown repository
Mar 17, 2014
Merged

libextra is deleted. extra::url has moved out to a separate library.#65
chris-morgan merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Mar 16, 2014

Hi. libextra was deleted from rust (rust-lang/rust#12896) so I went about removing all occurrences of extern crate extra. Also importing struct url::Url instead of importing from struct extra::url::Url. It was apparently the only library that was still being used that was in extra.

@Kroisse
Copy link
Copy Markdown
Contributor

Kroisse commented Mar 16, 2014

👍

@chris-morgan
Copy link
Copy Markdown
Owner

Littering extern crate url; throughout is not the correct way to do this sort of thing; in almost all cases, it should only be used at the crate root; in this case, it should certainly only be at the crate root.

@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 17, 2014

@chris-morgan sorry about that. I updated and squished the changes to declare extern crate url at the crate root only.

@chris-morgan
Copy link
Copy Markdown
Owner

Thanks, that looks better ☺

chris-morgan added a commit that referenced this pull request Mar 17, 2014
`libextra` is deleted. `extra::url` has moved out to a separate library.
@chris-morgan chris-morgan merged commit 06a2a8a into chris-morgan:master Mar 17, 2014
@ghost ghost deleted the rust-update-libextra-url branch March 17, 2014 13:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants