You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hmm, I think I tried to fix this for comments here: 9054d3c but didn't know it happens for stories too. If for comments, I feel that it's fine that one or two of them fails and "missing" from the response. But for stories... that's kinda weird 😕 especially when the API response looks like [STORY, STORY, null, STORY, STORY, ...].
Probably would be better to remove the null from the array?
I have handled it just by checking whether Item is nulll of not as below
Promise.all(itemFetches).then(function(res){
var apiRes = res.map(function(item){
if (item) { <--- Added this .. and this fixed this issue for me.
I think it would be better to remove the null from the array.
I was worried about [STORY, STORY, null, STORY, STORY, ...], but my FE handled null properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, one of the item returns null from firebase, and api fails with {"error":"Cannot read property 'descendants' of null"}