Issue #1038: upgrade maven-checkstyle-plugin to 3.6.0 and exclude dox…

[vivek-0509]

Issue #1038

• Upgraded maven-checkstyle-plugin from 3.1.1 to 3.6.0
• Excluded doxia-core and doxia-module-xdoc to prevent NoClassDefFoundError caused by doxia version conflict at runtime

[vivek-0509]

@romani
we are getting this errors

[WARNING] Error injecting: org.apache.maven.plugins.checkstyle.CheckstyleReport
java.lang.NoClassDefFoundError: org/apache/maven/doxia/siterenderer/DocumentContent
    at java.lang.Class.getDeclaredConstructors0 (Native Method)


R] urls[36] = file:/C:/Users/appveyor/.m2/repository/javax/servlet/servlet-api/2.5/servlet-api-2.5.jar
[ERROR] urls[37] = file:/C:/Users/appveyor/.m2/repository/org/apache/maven/doxia/doxia-decoration-model/1.4/doxia-decoration-model-1.4.jar
[ERROR] urls[38] = file:/C:/Users/appveyor/.m2/repository/org/apache/maven/doxia/doxia-site-renderer/1.4/doxia-site-renderer-1.4.jar

we also need to update the maven-site-plugin to the latest version
Should i update it in the same PR??

[romani]

hmm, this is wild .... I would expect that plugin will use its own dependency to Doxia

[vivek-0509]

i expect the same, let me test my reasoning once

[vivek-0509]

@romani
CI was failing because maven-checkstyle-plugin:3.6.0 requires doxia-site-renderer:2.0.0, but the actual maven-site-plugin running mvn site is still 3.3 (which ships with doxia-site-renderer:1.4).

The maven-site-plugin:3.3 in does NOT control which version runs the build. The actual execution version comes from Maven's hardcoded site lifecycle bindings, which defaults to 3.3:

site org.apache.maven.plugins:maven-site-plugin:3.3:site
site-deploy org.apache.maven.plugins:maven-site-plugin:3.3:deploy
reference:Maven 3.8.8 Lifecycles Reference

The CI log confirms this, even with 3.21.0 in , the build still uses 3.3

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.3:site (default-site) on project sample: Execution default-site of goal org.apache.maven.plugins:maven-site-plugin:3.3:site failed: A required class was missing while executing org.apache.maven.plugins:maven-site-plugin:3.3:site: org/apache/maven/doxia/siterenderer/DocumentContent

[INFO] configuring report plugin org.apache.maven.plugins:maven-site-plugin:3.21.0

report plugins run inside the site plugin's ClassRealm, so maven-checkstyle-plugin:3.6.0 cannot bring its own doxia-site-renderer, it must use whatever the site plugin provides. With 3.3, only doxia-site-renderer:1.4 is available, which doesn't have DocumentContent so we are gettiing NoClassDefFoundError.

i have added maven-site-plugin:3.21.0 in to override Maven's hardcoded default. This is the only place that controls the actual execution version.

[romani]

good !