Skip to content

Drop legacy browser support#8009

Merged
kurkle merged 5 commits into
chartjs:masterfrom
kurkle:remove-ie
Nov 16, 2020
Merged

Drop legacy browser support#8009
kurkle merged 5 commits into
chartjs:masterfrom
kurkle:remove-ie

Conversation

@kurkle

@kurkle kurkle commented Nov 4, 2020

Copy link
Copy Markdown
Member

Missed the button, was supposed to be draft.
Another option would be to add a chart.legacy.js or something, that would allow tracking usage of the dead weight.

@kurkle

kurkle commented Nov 4, 2020

Copy link
Copy Markdown
Member Author

Size Change: -15.8 kB (7%) ✅

Total Size: 213 kB

Filename Size Change
dist/chart.js 77.7 kB -11.2 kB (14%) 👏
dist/chart.min.js 56.4 kB -4.61 kB (8%)
ℹ️ View Unchanged
Filename Size Change
dist/chart.esm.js 62.4 kB 0 B
dist/chunks/helpers.segment.js 15.7 kB 0 B
dist/helpers.esm.js 989 B 0 B

@etimberg

etimberg commented Nov 4, 2020

Copy link
Copy Markdown
Member

Interesting idea. Not sure what impact this might have these days

@benmccann

Copy link
Copy Markdown
Contributor

It might be nice to document how users can build their own legacy version from the ESM build (what polyfills, babel settings, etc. are needed). That documentation would probably be helpful for npm users even if we end up keeping this

etimberg
etimberg previously approved these changes Nov 6, 2020
etimberg
etimberg previously approved these changes Nov 12, 2020
etimberg
etimberg previously approved these changes Nov 12, 2020
@kurkle

kurkle commented Nov 12, 2020

Copy link
Copy Markdown
Member Author

looks like the sourcemap is not correctly mapped in the coverage. i'll investigate a bit more

@kurkle

kurkle commented Nov 12, 2020

Copy link
Copy Markdown
Member Author

ok, coverage working the same now

@kurkle kurkle linked an issue Nov 14, 2020 that may be closed by this pull request
@kurkle kurkle merged commit 9101580 into chartjs:master Nov 16, 2020
@kurkle kurkle mentioned this pull request Nov 17, 2020
@kurkle kurkle deleted the remove-ie branch November 19, 2020 10:34
@kurkle kurkle mentioned this pull request Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is IE11 still supported in V3?

3 participants