Skip to content

Remove global from defaults#6893

Merged
etimberg merged 1 commit into
chartjs:masterfrom
kurkle:defaults
Jan 3, 2020
Merged

Remove global from defaults#6893
etimberg merged 1 commit into
chartjs:masterfrom
kurkle:defaults

Conversation

@kurkle

@kurkle kurkle commented Jan 2, 2020

Copy link
Copy Markdown
Member

Reduces 887 bytes from Chart.min.js

@kurkle kurkle added this to the Version 3.0 milestone Jan 2, 2020
etimberg
etimberg previously approved these changes Jan 2, 2020
benmccann
benmccann previously approved these changes Jan 3, 2020
@benmccann

Copy link
Copy Markdown
Contributor

@kurkle it looks like this PR will need to be rebased

benmccann
benmccann previously approved these changes Jan 3, 2020
etimberg
etimberg previously approved these changes Jan 3, 2020
@etimberg

etimberg commented Jan 3, 2020

Copy link
Copy Markdown
Member

Needs another rebase, sorry

@kurkle

kurkle commented Jan 3, 2020

Copy link
Copy Markdown
Member Author

Rebased

@etimberg etimberg merged commit f479230 into chartjs:master Jan 3, 2020
@kurkle kurkle deleted the defaults branch February 19, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants