Skip to content

PointLabels padding#5873

Closed
ketysek wants to merge 5 commits into
chartjs:masterfrom
ketysek:pointlabels-padding
Closed

PointLabels padding#5873
ketysek wants to merge 5 commits into
chartjs:masterfrom
ketysek:pointlabels-padding

Conversation

@ketysek

@ketysek ketysek commented Nov 30, 2018

Copy link
Copy Markdown

I've added pointLabels.padding settings option for radial charts to resolve the issue described here and attached in image bellow.

screen shot 2018-11-30 at 15 08 05

@kurkle kurkle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New option should be documented.

Same issue is addressed in #5914, but these do not conflict.

Comment thread src/scales/scale.radialLinear.js
@kurkle

kurkle commented Dec 16, 2018

Copy link
Copy Markdown
Member

@ketysek could you create a test fiddle for this PR?

@ketysek

ketysek commented Dec 17, 2018

Copy link
Copy Markdown
Author

@kurkle

kurkle commented Dec 17, 2018

Copy link
Copy Markdown
Member

I think the padding should also be considered when calculating space needed (goes out the top with padding 50):
pad50

@nagix thoughts?

@nagix

nagix commented Dec 20, 2018

Copy link
Copy Markdown
Contributor

@ketysek #5914 fixed this issue, but do you still have any reason to add padding option?

@ketysek

ketysek commented Dec 21, 2018

Copy link
Copy Markdown
Author

@nagix if the issue will be fixed then this PR is not necessary :-)

@ketysek ketysek closed this Dec 21, 2018
@mrleblanc101

Copy link
Copy Markdown

This issue is not solved by #5914, points can still overlap the labels
Capture d’écran, le 2021-03-09 à 12 58 46

@kurkle

kurkle commented Mar 9, 2021

Copy link
Copy Markdown
Member

@mrleblanc101 can you provide a reproduce of that?

@mrleblanc101

mrleblanc101 commented Mar 9, 2021

Copy link
Copy Markdown

@kurkle Just created a CodeSanbox.
I use Vue-chartjs, but I'm sure it's not related.
I could reproduce in vanilla chart.js.
https://codesandbox.io/s/autumn-frog-bel26?file=/components/RadarChart.vue

@mrleblanc101

Copy link
Copy Markdown

Just tell me if this issue will be re-opened or if I should create a new issue.

@kurkle

kurkle commented Mar 9, 2021

Copy link
Copy Markdown
Member

I think opening a new issue would be good. Vanilla repro: https://codepen.io/kurkle/pen/qBqQqxa

@mrleblanc101

Copy link
Copy Markdown

@kurkle Thanks I just did

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants