Make bar tests independent from scales#4686
Merged
Merged
Conversation
simonbrunel
approved these changes
Aug 23, 2017
simonbrunel
left a comment
Member
There was a problem hiding this comment.
LGTM, we could even hide the title and legend:
options: {
legend: false,
title: false
}@andig any desire to do that for all tests in controller.bar.tests.js :p
Contributor
Author
Looks like something a sane person would write a script for. Let me check after all the help I got here! Its just 384 more failures ;) |
Member
|
I think it could be scripted somewhat. A lot of the tests have similar values so once one or two are fixed it might be easier |
yofreke
pushed a commit
to yofreke/Chart.js
that referenced
this pull request
Dec 30, 2017
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare for changes of #4646 by making some tests less dependent.