Start of Animation plugin

[benmccann]

This stops some of the animation code (and dependencies such as helpers.easing) from being imported unless animations are being used. The animation plugin is somewhat minimal at the moment as a proof-of-concept, but there's a lot more we could move into the plugin. E.g. the next thing I'd like to move into the plugin are the animation options

[LeeLenaleee]

What is the reason for the name change?

[benmccann]

The plugin was also named Animation, so it was to avoid a clash. I thought about making the plugin something like AnimationPlugin, but none of the other plugins had a Plugin suffix. And I thought it'd be better to give the shorter name to the plugin because it's something users would use regularly whereas I think this class is only used in tests and unlikely to be referenced by users.

[stockiNail]

Forgive my question but moving animation as plugin should all options related to animation be moved in plugins.animation node to be aligned with all other plugins?

[benmccann]

Forgive my question but moving animation as plugin should all options related to animation be moved in plugins.animation node to be aligned with all other plugins?

Yes, that's exactly the plan. I just wanted to make sure people were generally okay with moving animation into a plugin. If so, I can make that change either in this PR or a follow up.

[kurkle]

I'd be ok having the animations as a plugin/extension.

If its not using any hooks, maybe it should not be a plugin. But it could as well use the start/stop or install/uninstall hooks to attach to the Chart.

The controller default animations need a little thought, because I don't think we can have all the defaults in the animation plugin. (External chart types for example)

The tooltip is similar in that its defaults might not be needed for a controller to register. Maybe we can have the animation defaults importable and registrable separately for each controller.

[stockiNail]

Yes, that's exactly the plan. I just wanted to make sure people were generally okay with moving animation into a plugin. If so, I can make that change either in this PR or a follow up.

Thank you @benmccann for feedback

The controller default animations need a little thought, because I don't think we can have all the defaults in the animation plugin. (External chart types for example)

@kurkle correct me if I'm wrong but also plugin default animations could be affected (i.e chart-plugin-annotation).

[kurkle]

The controller default animations need a little thought, because I don't think we can have all the defaults in the animation plugin. (External chart types for example)

@kurkle correct me if I'm wrong but also plugin default animations could be affected (i.e chart-plugin-annotation).

True, good point @stockiNail

[kurkle]

I guess this would need a bit more work to be efficient. Also I think this would fail miserably now with animations enabled in options and without the plugin registered.
The Animator should also be in the plugin (maybe the plugin should be called Animator to avoid SingleAnimation?)

[benmccann]

yeah, this is going to take more thought. i'll go ahead and close it for now