Skip to content

fix import helpers#10552

Merged
LeeLenaleee merged 1 commit into
chartjs:3.9from
LeeLenaleee:fix-import-helpers
Aug 3, 2022
Merged

fix import helpers#10552
LeeLenaleee merged 1 commit into
chartjs:3.9from
LeeLenaleee:fix-import-helpers

Conversation

@LeeLenaleee

@LeeLenaleee LeeLenaleee commented Aug 3, 2022

Copy link
Copy Markdown
Collaborator

Resolves: #10547

@etimberg

etimberg commented Aug 3, 2022

Copy link
Copy Markdown
Member

What's a good way to test this?

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok

@LeeLenaleee

LeeLenaleee commented Aug 3, 2022

Copy link
Copy Markdown
Collaborator Author

What's a good way to test this?

Steps I use to test these kind of things:

  1. Create clean project: npx create-react-app test-chartjs-changes
  2. Install chart.js: npm i chart.js
  3. Go into the node modules folder into chart.js and make the changes you want to test
  4. Remove the .bin and .cache folder in the root of the node modules
  5. Run npm i again so it builds all the packages again but with your own changes
  6. Import a helper function in App.js: import {merge} from 'chart.js/helpers'
  7. Put console log to see it got imported correctly: console.log(merge)
  8. Run npm start to run dev server
  9. It should build without errors and show the merge function in the console

@kurkle

kurkle commented Aug 3, 2022

Copy link
Copy Markdown
Member

We could add simple projects as integration tests for different platforms.

@LeeLenaleee
LeeLenaleee merged commit aa5e7e5 into chartjs:3.9 Aug 3, 2022
@LeeLenaleee

Copy link
Copy Markdown
Collaborator Author

@etimberg can you do a manual release of 3.9.1 because this also affects plugins.

@etimberg

etimberg commented Aug 3, 2022

Copy link
Copy Markdown
Member

Will do! I think it can be done entirely with the GitHub UI but will need to manually create the release on the correct branch.

@LeeLenaleee can you send a PR to the 3.9 branch bumping the package.json version number?

@LeeLenaleee
LeeLenaleee deleted the fix-import-helpers branch August 3, 2022 12:43
@LeeLenaleee
LeeLenaleee restored the fix-import-helpers branch August 3, 2022 12:57
@LeeLenaleee
LeeLenaleee deleted the fix-import-helpers branch August 3, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants