Skip to content

parsing: support dot(s) in object keys#10517

Merged
etimberg merged 1 commit into
chartjs:masterfrom
kurkle:parser-escape-dot
Jul 26, 2022
Merged

parsing: support dot(s) in object keys#10517
etimberg merged 1 commit into
chartjs:masterfrom
kurkle:parser-escape-dot

Conversation

@kurkle

@kurkle kurkle commented Jul 25, 2022

Copy link
Copy Markdown
Member

Closes #10348
Closes #10501

@thabarbados sorry for stepping on your pr, but as I already put some time to it, I figured its less time spend for everyone if I post this.

This performs consistently a little bit better than master on the default parsing case (uPlot dataset):

pr:

50 runs done in 3389ms. Average: 67ms, min: 57ms, max: 127ms, variation: 70ms.

master:

50 runs done in 3602ms. Average: 72ms, min: 62ms, max: 135ms, variation: 73ms.

@thabarbados

Copy link
Copy Markdown
Contributor

@kurkle No problem! It's great that you found a faster solution!

@thabarbados

Copy link
Copy Markdown
Contributor

@kurkle, what do you think about adding performance tests? I think it would help new contributors. If you don't mind, I can try to realize it.

@kurkle

kurkle commented Jul 26, 2022

Copy link
Copy Markdown
Member Author

@kurkle, what do you think about adding performance tests? I think it would help new contributors. If you don't mind, I can try to realize it.

That would be great!

@thabarbados

Copy link
Copy Markdown
Contributor

@kurkle awesome! Can you share with me your large database and how you checked performance? I think this will be a good starting point.
If you don't mind, you can email it to thabarbados@gmail.com

@kurkle

kurkle commented Jul 26, 2022

Copy link
Copy Markdown
Member Author

I've been usin uPlot bench dataset, available at https://github.com/leeoniya/uPlot/blob/master/bench/data.json

The data needs some pre-prosessing though. (See the chart.js bench at uPlot, that one is a good starting point)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow escaping '.' in parsing *AxisKey

4 participants