feat(tdbg): schedule dedup and force-CAN commands by chaptersix · Pull Request #19 · chaptersix/temporal

chaptersix · 2026-04-09T23:07:56Z

What changed?

Added schedule dedup and schedule force-can subcommands to tdbg.
The implementation lives in tools/schedutil/ (library) and tools/tdbg/schedule_dedup_commands.go (CLI wiring). All operations go through the workflowservice gRPC API directly — no SDK client.
dedup targets a single schedule (--schedule-id), piped IDs from stdin, or all schedules in the namespace. Without --execute it writes before/after JSON artifacts and exits without modifying anything.
dedup --recreate handles schedules too degraded to process an update: reads StartScheduleArgs from workflow history, deduplicates proto-level StructuredCalendar entries, then (with --execute) deletes and recreates the schedule via CreateSchedule. High watermark resets to now; actions that would have fired during the degraded period will not fire.
force-can sends a force-continue-as-new signal to the scheduler workflow. Supports the same targeting model and dry-run toggle as dedup.
Dedup uses proto.Equal after normalizing range defaults (End, Step) to match cleanSpec semantics. Entries that differ only in proto default representation are treated as equal; entries with different Comment fields are treated as distinct.
Added FlagExecute and FlagRecreate to tools/tdbg/flags.go.

How did you test it?

built
added new unit tests (tools/schedutil/schedutil_test.go)
added new functional tests (tests/schedutil_test.go)

go test ./tools/schedutil/... ./tools/tdbg/... -count=1
go test -tags "disable_grpc_modules,test_dep" ./tests/ -run TestSchedUtil -count=1

Sample commands

# Single schedule — dry run (writes before/after JSON, no changes applied)
tdbg -namespace prod schedule dedup --schedule-id my-sched

# Single schedule — apply
tdbg -namespace prod schedule dedup --schedule-id my-sched --execute

# Subset via pipe
temporal schedule list -n prod -o json | jq -r '.[].scheduleId' | \
    tdbg -namespace prod schedule dedup --execute

# Recreate a degraded schedule (dry run then apply)
tdbg -namespace prod schedule dedup --schedule-id my-sched --recreate
tdbg -namespace prod schedule dedup --schedule-id my-sched --recreate --execute

# Force continue-as-new
tdbg -namespace prod schedule force-can --schedule-id my-sched --execute

lina-temporal · 2026-04-13T18:40:25Z

+	attrs := resp.History.Events[0].GetWorkflowExecutionStartedEventAttributes()
+	if attrs == nil {
+		return errors.New("first event is not WorkflowExecutionStarted")
+	}


I think we'd actually want to look at the latest memo, not the first (so basically the top event that has a full schedule in it). Otherwise, we'd potentially miss an update, aside from the inadvertent accumulation of duplicates.

The memo isn't enough, right? I would look from back to front for the last update signal payload. (And then replay any patch signals over that)

lina-temporal · 2026-04-13T18:46:34Z

+// query size limit), deduplicates the spec, and (if execute) deletes the broken
+// schedule and recreates it with the clean spec. Use when the workflow is too
+// degraded to process an update signal.
+func RunDedupRecreate(ctx context.Context, cl sdkclient.Client, namespace, scheduleID, outDir string, execute bool) error {


I'm assuming that the way we'll run this is with a small hand-evaluated file of schedules to target, versus "entire namespace", correct? One thing that might be useful as a failsafe would be to check and see if the schedule "looks" stuck (e.g., if the top events aren't "timer started" after "WFT completion"). I don't want to go overkill on a purpose-built tool like this, but I think the usefulness of the failsafe scales with the volume of input we plan to feed into it. WDYT?

Yes, we'd only run this one a subset of schedules. Easiest indicator will be if it can't respond to a describe schedule request. For debup without recreate and execute it will iterate over all schedules in a namespace and describe them. it will return an error (probably not one that's easy to parse) if it can not describe the schedule. We can use recreate on those.

we can use the piped input to run this on a larger subset.

Adds schedutil, a CLI tool with two commands: dedup - prints the current spec as JSON, deduplicates StructuredCalendar and Interval entries client-side, then sends an UpdateSchedule. Works without any server-side fix. force-can - sends force-continue-as-new to the scheduler workflow. Three targeting modes: --schedule-id <id> single schedule --ids-file <file> file of IDs, one per line ('-' for stdin) (neither) all schedules in the namespace Namespace-wide and file modes require --yes; without it the command lists affected schedules and exits. Flags and env vars mirror tdbg (TEMPORAL_CLI_ADDRESS, TLS certs, TEMPORAL_CLI_NAMESPACE, TEMPORAL_CONTEXT_TIMEOUT).

Co-authored-by: Lina Jodoin <lina.jodoin@temporal.io>

…n mode Without --execute the command always describes each schedule, writes before/after JSON files to a temp directory, and exits without applying any changes. With --execute the same files are written and changes are applied. - Renames --yes to --execute - RunDedup writes <ns>_<sid>-before.json and <ns>_<sid>-after.json to a shared temp dir regardless of execute flag - RunForceCAN prints what would be signalled in dry-run mode - ForEachSchedule drops the yes/execute param — callers own that logic - Adds dry-run integration tests for both dedup and force-can

Removes --ids-file. Without --schedule-id, reads IDs one per line from stdin if piped, otherwise operates on all schedules in the namespace. Standard Unix behavior, no extra flag needed.

When a schedule workflow is too degraded to respond to queries or signals (spec too large), --recreate reads the schedule state directly from workflow history, deduplicates the spec, deletes the broken workflow, and recreates the schedule fresh. Reads StartScheduleArgs from the WorkflowExecutionStarted event using payloads.Decode (binary/protobuf encoding used by the frontend). Deduplicates StructuredCalendar and Interval entries using proto.Equal directly on the proto types — no normalization needed since all entries from workflow history are in identical wire form. Preserves the full schedule state (action, policies, paused status, remaining actions) since StartScheduleArgs carries the current mutable state via ContinueAsNew arguments. Adds unit tests for the proto dedup helpers and functional tests for both dry-run and execute modes.

dnr · 2026-04-13T20:17:01Z

+	attrs := resp.History.Events[0].GetWorkflowExecutionStartedEventAttributes()
+	if attrs == nil {
+		return errors.New("first event is not WorkflowExecutionStarted")
+	}


The memo isn't enough, right? I would look from back to front for the last update signal payload. (And then replay any patch signals over that)

…and group

…ommands

… detection

…eate

…iterator

…ailure

chaptersix force-pushed the tools/schedule-spec-util branch from 34829cb to 74f51c5 Compare April 9, 2026 23:09

chaptersix commented Apr 10, 2026

View reviewed changes

Comment thread tools/schedutil/schedutil.go Outdated

chaptersix commented Apr 10, 2026

View reviewed changes

Comment thread tools/schedutil/schedutil.go Outdated

chaptersix commented Apr 10, 2026

View reviewed changes

Comment thread tools/schedutil/schedutil.go Outdated

chaptersix force-pushed the tools/schedule-spec-util branch from ad6744a to 404b1c9 Compare April 10, 2026 16:12

chaptersix marked this pull request as ready for review April 10, 2026 17:36

lina-temporal reviewed Apr 10, 2026

View reviewed changes

chaptersix marked this pull request as draft April 13, 2026 16:22

chaptersix marked this pull request as ready for review April 13, 2026 16:28

lina-temporal reviewed Apr 13, 2026

View reviewed changes

chaptersix and others added 9 commits April 13, 2026 14:44

Update tools/schedutil/schedutil.go

a471a69

Co-authored-by: Lina Jodoin <lina.jodoin@temporal.io>

feat(schedutil): simplify targeting — pipe stdin or whole namespace

39fc05f

Removes --ids-file. Without --schedule-id, reads IDs one per line from stdin if piped, otherwise operates on all schedules in the namespace. Standard Unix behavior, no extra flag needed.

feat(schedutil): dump full schedule in before/after JSON files

ff48cbd

docs(schedutil): add --recreate example to help description

64a0d25

fix(schedutil): skip no-op outputs and preserve calendar comments

3d82dba

refactor(schedutil): limit dedup to structured calendars

0a0533b

chaptersix force-pushed the tools/schedule-spec-util branch from 2cd70e1 to 0a0533b Compare April 13, 2026 19:44

chaptersix added 2 commits April 13, 2026 15:02

fix(schedutil): address PR review comments

b0aaa74

fix(schedutil): address PR review comments

c808520

dnr reviewed Apr 13, 2026

View reviewed changes

chaptersix added 4 commits April 13, 2026 15:32

refactor(schedutil): move dedup and force-can into tdbg schedule comm…

658b366

…and group

refactor(tdbg): drop Admin prefix from schedule dedup and force-can c…

d1008e0

…ommands

refactor(schedutil): replace SDK client with workflowservice gRPC client

ba51e46

fix(schedutil): use common.CloneProto and protojson.Marshal consistently

6236487

chaptersix changed the title ~~feat(tools): schedutil — schedule spec dedup and force-CAN~~ feat(tdbg): schedule dedup and force-CAN commands Apr 13, 2026

chaptersix added 2 commits April 13, 2026 15:54

chore: remove sdk replace directive and use term.IsTerminal for stdin…

3ceb4b7

… detection

feat(schedutil): reconstruct schedule from history signals for --recr…

3312f90

…eate

test(schedutil): add unit tests for replayScheduleHistory with event …

664e1e4

…iterator

dnr approved these changes Apr 13, 2026

View reviewed changes

Comment thread tools/schedutil/schedutil.go Outdated

Comment thread tools/schedutil/schedutil.go Outdated

lina-temporal approved these changes Apr 13, 2026

View reviewed changes

Comment thread tools/schedutil/schedutil.go Outdated

chaptersix added 3 commits April 13, 2026 17:27

fix(schedutil): use iter.Seq2 for history iterator, abort on decode f…

44057dd

…ailure

fix(schedutil): add default case to switch for revive linter

e2eb1e8

fix(tdbg): use per-operation context for namespace-wide schedule dedup

a1a326e

chaptersix mentioned this pull request Apr 29, 2026

fix: deduplicate schedule StructuredCalendar entries on create/update temporalio/temporal#10113

Open

4 tasks

Conversation

chaptersix commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed?

How did you test it?

Sample commands

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lina-temporal Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

dnr Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lina-temporal Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

chaptersix Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

chaptersix Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dnr Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chaptersix commented Apr 9, 2026 •

edited

Loading