Skip to content

feat(settings): group settings into Timeline and Call Tree categories#808

Merged
lcottercertinia merged 2 commits into
certinia:mainfrom
lukecotter:feature-settings-feat-grouping
Jun 17, 2026
Merged

feat(settings): group settings into Timeline and Call Tree categories#808
lcottercertinia merged 2 commits into
certinia:mainfrom
lukecotter:feature-settings-feat-grouping

Conversation

@lukecotter

Copy link
Copy Markdown
Collaborator

📝 PR Overview

Restructure the extension's settings contribution so the VS Code Settings UI shows separate Timeline and Call Tree categories with clean inline labels. Setting IDs are unchanged, so existing user configuration keeps working.

🛠️ Changes made

  • Convert contributes.configuration from a single object to an array of blocks, each with id: "lana" and a distinct title — produces separate Timeline / Call Tree sections in the settings table of contents while keeping inline "Timeline: …" labels (the shared lana prefix is stripped).
  • Soft-deprecate the legacy Timeline: reword lana.timeline.legacy as a temporary fallback that will be removed in a future release, and note lana.timeline.colors is legacy-only and being phased out. No hard "Deprecated" badge yet — the toggle is a deliberate escape hatch.
  • Tighten the categoryColorize description and standardize "Default: false" wording.

Most of the diff line count is reindentation from wrapping the existing object in the array form; the semantic change is small.

🧩 Type of change (check all applicable)

  • 🐛 Bug fix - something not working as expected
  • ✨ New feature – adds new functionality
  • ♻️ Refactor - internal changes with no user impact
  • ⚡ Performance Improvement
  • 📝 Documentation - README or documentation site changes
  • 🔧 Chore - dev tooling, CI, config
  • 💥 Breaking change

📷 Screenshots / gifs / video [optional]

VS Code Settings UI grouping only; no webview change.

✅ Tests added?

  • 👍 yes
  • 🙅 no, not needed
  • 🙋 no, I need help

📚 Docs updated?

  • 🔖 README.md
  • 🔖 CHANGELOG.md
  • 📖 help site
  • 🧪 Marked any pre-release-only features (README 🧪 badge — see RELEASING.md)
  • 🙅 not needed

Anything else we need to know? [optional]

Backwards compatible: no setting IDs changed, so values in users' settings.json continue to apply. Follow-up: add a real markdownDeprecationMessage to lana.timeline.colors in the release before the legacy Timeline is removed.

Setting IDs are unchanged, so existing user values keep working.

- convert `configuration` from a single object to an array of blocks, each with `id:
"lana"` + a distinct title, yielding separate Timeline/Call Tree sections that
retain inline "Timeline: …" labels
- soft-deprecate the legacy Timeline: reword `lana.timeline.legacy` as a temporary
fallback and note `lana.timeline.colors` is legacy-only and being phased out
- tighten the `categoryColorize` description and standardize "Default: false"
wording
@lcottercertinia lcottercertinia merged commit eb494d0 into certinia:main Jun 17, 2026
7 checks passed
@lukecotter lukecotter deleted the feature-settings-feat-grouping branch June 17, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants