This repository was archived by the owner on Oct 3, 2023. It is now read-only.
Set defaults for sameProcessAsParentSpan #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first span defaults to false (from an external process). Subsequent spans default to true (running in the same PHP process).
tmatsuo
reviewed
Mar 29, 2018
| if (method_exists($span, 'sameProcessAsParentSpan')) { | ||
| return $span->sameProcessAsParentSpan(); | ||
| } | ||
| return true; |
Contributor
There was a problem hiding this comment.
When this happens? and is it ok to always return true?
Member
Author
There was a problem hiding this comment.
This would happen if they have an older version of the extension.
We could try to do a workaround to try and set the first span's value to false, but it's probably not worth it.
tmatsuo
approved these changes
Apr 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first span defaults to false (from an external process).
Subsequent spans default to true (running in the same PHP process).
Fixes #122