Skip to content

Add 'test all' definitions - #296

Merged
TristonianJones merged 2 commits into
cel-expr:masterfrom
Alfus:afuller/testall
Jul 6, 2023
Merged

Add 'test all' definitions#296
TristonianJones merged 2 commits into
cel-expr:masterfrom
Alfus:afuller/testall

Conversation

@Alfus

@Alfus Alfus commented Jun 26, 2023

Copy link
Copy Markdown
Contributor

To complete the set of local .proto definitions for the conformance tests. Note that the uri's of the Any's in the conformance test data will need to be updated to migrate to these definitions.

@Alfus

Alfus commented Jun 30, 2023

Copy link
Copy Markdown
Contributor Author

Results in the packages:
image

@TristonianJones

Copy link
Copy Markdown
Collaborator

/gcbrun

@TristonianJones TristonianJones self-assigned this Jul 5, 2023
@TristonianJones
TristonianJones self-requested a review July 5, 2023 18:12
@TristonianJones TristonianJones removed their assignment Jul 5, 2023
@TristonianJones

Copy link
Copy Markdown
Collaborator

/gcbrun

@TristonianJones

Copy link
Copy Markdown
Collaborator

/gcbrun

@TristonianJones

Copy link
Copy Markdown
Collaborator

@Alfus running the bazel build locally seems to be fine. I'm not sure why Cloud Build is unhappy, but I'll merge soon and sort out the GCB issues separately given the local builds / tests seem fine.

@TristonianJones
TristonianJones merged commit 0c84135 into cel-expr:master Jul 6, 2023
@Alfus
Alfus deleted the afuller/testall branch July 14, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants