Add option to use inaccessible accumulator var#1097
Merged
Conversation
jnthntatum
force-pushed
the
restrict-accu-var
branch
3 times, most recently
from
December 17, 2024 21:39
690e79c to
dc1bbd5
Compare
jnthntatum
marked this pull request as ready for review
December 17, 2024 22:07
Add an option to use '@Result' as the accumulator variable for builtin comprehensions. The current default "__result__" is accesible in the CEL Source, allowing for expressions to type check but lead to unexpected or incorrect results. '@Result' isn't a normally accessible identifier in the source expression so a bit safer as a default.
jnthntatum
force-pushed
the
restrict-accu-var
branch
from
January 7, 2025 19:59
dc1bbd5 to
f906279
Compare
TristonianJones
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an option to use
@resultas the accumulator variable for builtin comprehensions. The current default__result__is accessible in the CEL Source, allowing for expressions to type check but lead to unexpected or incorrect results.@result'isn't a normally accessible identifier in the source expression so a bit safer as a default.