This repository was archived by the owner on Mar 4, 2022. It is now read-only.
Conversation
dsamojlenko
approved these changes
Dec 24, 2019
jeffmaher
added a commit
that referenced
this pull request
Dec 27, 2019
This reverts commit ec2a015.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A request came from CDS security to migrate ESDC collaborators from the CDS GitHub teams to GitHub Outside Collaborators to more tightly control permissions in our GitHub org. Unfortunately, this removed our ability to group reviewers by role due to not being able to associate ESDC team members with a GitHub team. The following situation arose:
For example, to force a dev code review in the past we could do this:
But now, since ESDC folks can't be on GitHub teams as outside collaborators, we'd have something like this:
This forces both a member of the esdc-cppd-devs AND Calvin to have to approve, meaning Calvin has to approve everything even if either Dave or I have. For policy-related changes, for example, we'd need BOTH Jane and Kyle to approve, not just one of them. This creates a ton of unnecessary bottle necking as we aim to make small changes rapidly.
We'll still try to do this process via honor code (after all, we trust our people), but unfortunately there is no enforcement mechanism given the mix of GitHub functionality (i.e. there is no
ORin GitHub CODEOWNERS) and CDS policy.