Skip to content

Change the axis color of workflow metrics to match GitHub theme setting#69

Open
massongit wants to merge 1 commit into
catchpoint:masterfrom
massongit:change_theme
Open

Change the axis color of workflow metrics to match GitHub theme setting#69
massongit wants to merge 1 commit into
catchpoint:masterfrom
massongit:change_theme

Conversation

@massongit

@massongit massongit commented May 22, 2024

Copy link
Copy Markdown
Contributor

@massongit

Copy link
Copy Markdown
Contributor Author

@rwxdash @suleymanbarman Please review it.

@massongit

Copy link
Copy Markdown
Contributor Author

@rwxdash @suleymanbarman @serkan-ozal Please review it.

@BourgoisMickael

Copy link
Copy Markdown

Maybe you can assign them as reviewers to notify them

@massongit

Copy link
Copy Markdown
Contributor Author

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review

To assign a reviewer to a pull request, you will need write access to the repository.

I do not have permission to assign reviewers...

@BourgoisMickael

Copy link
Copy Markdown

Can you include a screenshot to show the graphs works well in dark mode

@massongit

Copy link
Copy Markdown
Contributor Author

I add screenshots to PR description.

@massongit massongit closed this Mar 1, 2025
@massongit massongit reopened this Mar 1, 2025
@echoix

echoix commented Mar 1, 2025

Copy link
Copy Markdown

I can confirm it looks the same as the screenshot on GitHub mobile on iOS (from the test PR linked)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

theme: dark option not working as expected

3 participants