Skip to content

feat: add pydantic models for projects endpoint - #26

Merged
aliaksei-kuchyk merged 4 commits into
developfrom
feat/add-pydantic-models
Jul 22, 2024
Merged

feat: add pydantic models for projects endpoint #26
aliaksei-kuchyk merged 4 commits into
developfrom
feat/add-pydantic-models

Conversation

@aliaksei-kuchyk

Copy link
Copy Markdown
Contributor

Motivation

As a user of this package I would like to use type checking for my payloads for projects endpoint to be sure I am sending valid requests before API actually returns error response.

Solution

Added pydantic models and some tests

TODO

  • Cover functionality with tests

@bhodorog bhodorog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pdeburen

Copy link
Copy Markdown
Contributor

@aliaksei-kuchyk noticed that this is still not merged, anything left to do? do the guides need to be updated https://caplena.com/docs/sdk/python/creating-projects.html ?

@aliaksei-kuchyk

Copy link
Copy Markdown
Contributor Author

Totally forgot about this one. Yes, documentation needs to be updated.

@pdeburen

Copy link
Copy Markdown
Contributor

Totally forgot about this one. Yes, documentation needs to be updated.

Ok, can you do this?

@aliaksei-kuchyk

Copy link
Copy Markdown
Contributor Author

@pdeburen done, should I merge?

@aliaksei-kuchyk
aliaksei-kuchyk merged commit 76ce153 into develop Jul 22, 2024
pdeburen added a commit that referenced this pull request May 22, 2026
* fix(APP-3160): fix update row (#25)

* fix(APP-3160): fix update row

* fix(APP-3160): update version

* feat: add pydantic models for projects endpoint  (#26)

* feat: add pydantic models

* feat: update version

* feat: correct version

* feat: update docs

* fix(app-3632): fix project urls (#27)

* fix(app-7951): change default tta cell was_reviewed attribute (#28)

* fix(app-8436): add explanation of the `TTACell.was_reviewed` flag (#29)

* feat: support inverted filters via ~ operator (#30)

* feat: support inverted filters via ~ operator

Add filter negation with the unary ~ operator, serializing inverted
constraints with ! instead of : to match the API. Escape ! in filter
values and document inverted filters in the SDK docs.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix: address PR review feedback for inverted filters

Tag inverted clauses from both operands in __and__, reset top-level
is_inverted after merge, show inversion in __str__, fix RST underline,
and add tests for inverted-left AND and cross-filter combinations.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix: resolve mypy errors for inverted clause metadata

Introduce FilterClause type allowing bool inversion markers alongside
filter value lists, and narrow types when merging clause values.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>

* chore: update SDK version number and replace old logo (#31)

---------

Co-authored-by: aliaksei-kuchyk <aliaksei.kuchyk@protonmail.com>
Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants