docs: clarify storage-detaching applies to both machine and K8s charms#2554
Open
tonyandrewmeyer wants to merge 6 commits into
Open
Conversation
… and K8s charms
Verified against Juju 3.6.23: `juju remove-storage` on attached storage is rejected unless `--force` is passed (the user is prompted to run `juju detach-storage` first). Tighten the storage-detaching docs to reflect that the event fires from `juju detach-storage` or `juju remove-storage --force`.
Collaborator
Author
|
3.10 failures are unrelated (as one would hope for a docs PR). Will be fixed by another PR and rebasing will fix here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I double-checked the items in the issue against Juju 3.6.23. A minimal
opscharm observedstorage-attached,storage-detaching,stop, andremoveand logged each event.juju detach-storageemitsstorage-detachingSTORAGE-TEST: storage-detaching event for /var/lib/storage-test/data/3juju remove-storageemitsstorage-detachingSTORAGE-TEST: storage-detaching event for /var/lib/storage-test/data/4(requires--forcewhile attached)data/5storage-detaching fired beforestop/removeonjuju remove-application --destroy-storagejuju detach-storagereturnsERROR Juju command "detach-storage" not supported on container models(verbatim)storage-detachingfires during unit teardowndata/0storage-detaching fired beforestop/removeonjuju remove-application --destroy-storagePreview
Fixes #2257