Skip to content

Conversation

@arturo-seijas
Copy link
Collaborator

@arturo-seijas arturo-seijas commented May 7, 2024

Applicable spec:
N/A

Overview

Remove the site_url configuration option and configure the external hostname through the nginx-route relation.

Rationale

N/A

Juju Events Changes

N/A

Module Changes

charm.py

Library Changes

NA

Checklist

@canonical canonical deleted a comment from github-actions bot May 7, 2024
@canonical canonical deleted a comment from github-actions bot May 10, 2024
@canonical canonical deleted a comment from github-actions bot May 10, 2024
@arturo-seijas arturo-seijas reopened this May 20, 2024
@alithethird
Copy link
Contributor

@arturo-seijas what should we do with this one?

@github-actions
Copy link
Contributor

Test results for commit 3f58153

Lint checks failed for 3f58153

```

--- /home/ubuntu/actions-runner/_work/indico-operator/indico-operator/src/charm.py:before 2025-05-26 07:00:37.810000
+++ /home/ubuntu/actions-runner/_work/indico-operator/indico-operator/src/charm.py:after 2025-05-26 07:01:02.784277
@@ -13,8 +13,8 @@
import charms.loki_k8s.v0.loki_push_api
import ops
from charms.grafana_k8s.v0.grafana_dashboard import GrafanaDashboardProvider
+from charms.loki_k8s.v0.loki_push_api import LogProxyConsumer
from charms.nginx_ingress_integrator.v0.nginx_route import NginxRouteRequirer, require_nginx_route
-from charms.loki_k8s.v0.loki_push_api import LogProxyConsumer
from charms.prometheus_k8s.v0.prometheus_scrape import MetricsEndpointProvider
from charms.redis_k8s.v0.redis import RedisRelationCharmEvents, RedisRequires
from ops.charm import ActionEvent, CharmBase, HookEvent, PebbleReadyEvent, RelationDepartedEvent

@github-actions
Copy link
Contributor

Test results for commit 3f58153

Test coverage for 3f58153

Name                       Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------------
src/charm.py                 330     12     74      8    95%   374, 388-389, 639, 676-677, 768->784, 770->779, 779->784, 792-793, 832, 865->exit, 903-909
src/database_observer.py      32      0      4      0   100%
src/s3_observer.py            17      0      0      0   100%
src/saml_observer.py          14      0      0      0   100%
src/smtp_observer.py          15      0      0      0   100%
src/state.py                  73      0      8      0   100%
----------------------------------------------------------------------
TOTAL                        481     12     86      8    96%
Coverage failure: total of 96 is less than fail-under=97

Static code analysis report

Run started:2025-05-26 07:01:10.300400

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 3064
  Total lines skipped (#nosec): 3
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants