PHP 8.1 support#173
Merged
Merged
Conversation
markstory
reviewed
Aug 8, 2022
| "require": { | ||
| "php": "^7.2", | ||
| "php": ">=7.4.0", | ||
| "cakephp/cakephp": "^4.0", |
Contributor
Author
There was a problem hiding this comment.
@markstory You mean cakephp/cakephp ^4.3 ?
Contributor
Author
There was a problem hiding this comment.
The only reason I didn't was because only the tests need CakePHP 4.3, but that's really a decision for you guys
Member
There was a problem hiding this comment.
Doesn't changing the min PHP version effectively bump up the cake version as well though?
Contributor
Author
There was a problem hiding this comment.
I've rebased the PHP version to >=7.2 so we don't force a cakephp version bump
rcbrites
approved these changes
Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs
https://wiki.php.net/rfc/deprecations_php_8_1#ctype_function_family_accepts_int_parameters
https://www.php.net/manual/en/function.ctype-digit.php