Conversation
… Form Co-authored-by: jbrooksuk <246103+jbrooksuk@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix method signature issue in ManageLocalization class
Fix ManageLocalization form method signature compatibility with SettingsPage
Aug 31, 2025
jbrooksuk
added a commit
that referenced
this pull request
Sep 13, 2025
* main: Build assets Bump vite from 5.4.19 to 5.4.20 (#296) Compile Assets Fix ManageLocalization form method signature compatibility with SettingsPage (#294) Add Manage Localization Page (#285) Compile Assets Fix accent color theme swatch Revert composer.json name change Compile Assets Add "Under maintenance" status to components and systems (#287) Filament v4 (#292) Compile Assets Fix Incident and Updates message size (#290)
jbrooksuk
added a commit
to icecoldPHP/cachet-core
that referenced
this pull request
Sep 13, 2025
* main: (73 commits) Bump dependencies Add option to show metrics even when empty (cachethq#297) Compile Assets Build assets Bump vite from 5.4.19 to 5.4.20 (cachethq#296) Compile Assets Fix ManageLocalization form method signature compatibility with SettingsPage (cachethq#294) Add Manage Localization Page (cachethq#285) Compile Assets Fix accent color theme swatch Revert composer.json name change Compile Assets Add "Under maintenance" status to components and systems (cachethq#287) Filament v4 (cachethq#292) Compile Assets Fix Incident and Updates message size (cachethq#290) Bump some dependencies Updated language files (German & Dutch) (cachethq#281) Add demo server fix; Missing webhook events in WebhookListener list (cachethq#283) ...
jbrooksuk
added a commit
to icecoldPHP/cachet-core
that referenced
this pull request
Sep 13, 2025
* main: (50 commits) Timezone switch on status page (cachethq#191) (cachethq#233) Install Laravel Boost and configure Claude Code (cachethq#291) Don't use native datetime picker in Filament (cachethq#298) Bump dependencies Add option to show metrics even when empty (cachethq#297) Compile Assets Build assets Bump vite from 5.4.19 to 5.4.20 (cachethq#296) Compile Assets Fix ManageLocalization form method signature compatibility with SettingsPage (cachethq#294) Add Manage Localization Page (cachethq#285) Compile Assets Fix accent color theme swatch Revert composer.json name change Compile Assets Add "Under maintenance" status to components and systems (cachethq#287) Filament v4 (cachethq#292) Compile Assets Fix Incident and Updates message size (cachethq#290) Bump some dependencies ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ManageLocalizationclass was throwing a PHP Fatal error due to an incompatible method signature between itsform()method and the parentSettingsPageclass.Problem
The error occurred because:
This caused the fatal error:
Solution
Updated
ManageLocalizationto match the pattern used by all other settings pages (ManageCachet,ManageCustomization,ManageTheme):Filament\Forms\FormwithFilament\Schemas\Schemaand individual component importsform(Schema $schema): SchemaForms\Components\*namespace to direct component imports->schema([...])to->components([...])The fix maintains all existing functionality while resolving the fatal compatibility error and ensuring consistency across all settings pages.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/amphp/parser/zipball/3cf1f8b32a0171d4b1bed93d25617637a77cded7/usr/bin/php8.3 -n -c /tmp/ri4Uic /usr/bin/composer install(http block)https://api.github.com/repos/revoltphp/event-loop/zipball/09bf1bf7f7f574453efe43044b06fafe12216eb3/usr/bin/php8.3 -n -c /tmp/ri4Uic /usr/bin/composer install(http block)If you need me to access, download, or install something from one of these locations, you can either:
This pull request was created as a result of the following prompt from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.