Skip to content

Add new watermark algorithm entry to JSON list#41

Open
c2pamarkany wants to merge 2 commits intoc2pa-org:mainfrom
c2pamarkany:main
Open

Add new watermark algorithm entry to JSON list#41
c2pamarkany wants to merge 2 commits intoc2pa-org:mainfrom
c2pamarkany:main

Conversation

@c2pamarkany
Copy link

About

MarkAny invisible watermarking with robustness against cropping, resizing, and compression.

Submitter Affiliation

Submitted by MarkAny Co., Ltd., a C2PA Contributor Member.

Copy link
Collaborator

@domguinard domguinard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your entry. It is valid but may I ask for 2 suggestions:

  1. Can you indent your entry like the previous ones (the indentation is off a little)
  2. You may want to consider adding a version identifier to your alg field (e.g., com.markany.watermark.1) this is not a must but it could help if you have several versions.

Copy link
Collaborator

@domguinard domguinard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I checked the contact email and it does not resolve. Could you add a valid email?
Adding the small suggestions here too:

  • Can you indent your entry like the previous ones (the indentation is off a little)
  • You may want to consider adding a version identifier to your alg field (e.g., com.markany.watermark.1) this is not a must but it could help if you have several versions.

Updated the algorithm identifier and algorithm name, and modified the contact email for MarkAny watermarking.
@c2pamarkany
Copy link
Author

@domguinard
Thank you for the review! Addressed all feedback:

  • Fixed contact email to c2pa@markany.co.kr (valid and reachable)
  • Fixed indentation to match existing entries (4 spaces)
  • Added version identifier: com.markany.watermark.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants