HOTFIX: Fix stream_set_blocking call in StreamSocketClient::buildSocket for UDP streams#164
Open
r00t3g wants to merge 1 commit into
Open
HOTFIX: Fix stream_set_blocking call in StreamSocketClient::buildSocket for UDP streams#164r00t3g wants to merge 1 commit into
r00t3g wants to merge 1 commit into
Conversation
…lient::buildSocket for UDP streams
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason during transport modernization in f2625cf
, UDP sockets started to be set in blocking mode rather than non-blocking.
According to PHP Docs passing true to stream_set_blocking will make stream blocking which contradicts the comment before the call.