Skip to content

Update to the latest spec_testsuite and dependencies.#803

Merged
sunfishcode merged 2 commits intobytecodealliance:masterfrom
sunfishcode:update-submodules
Jan 10, 2020
Merged

Update to the latest spec_testsuite and dependencies.#803
sunfishcode merged 2 commits intobytecodealliance:masterfrom
sunfishcode:update-submodules

Conversation

@sunfishcode
Copy link
Member

Update to target-lexicon 0.10, cranelift 0.54, wast 0.6, faerie 0.14,
and the latest spec_testsuite.

For wast and cranelift-wasm, update the code for API changes.

@alexcrichton
Copy link
Member

Oh heh the wast update is also happening in #802! I'll take a look at this as well

Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @abrown, this may subsume #802 perhaps?

@sunfishcode
Copy link
Member Author

Oops, sorry for duplicating work here!

Also, I mangled a conflict resolution here; I'll fix that.

Update to target-lexicon 0.10, cranelift 0.54, wast 0.6, faerie 0.14,
and the latest spec_testsuite.

For wast and cranelift-wasm, update the code for API changes.
@sunfishcode
Copy link
Member Author

Ok, the merge conflict is sorted now.

This takes the idea from bytecodealliance#802 to split out `f32_matches`, `f64_matches`,
and `v128_matches` functions, which better factor out the matching
functionality between scalar and vector.
@abrown
Copy link
Member

abrown commented Jan 10, 2020

No worries; I think this does more than #802 so I'll close that one.

@sunfishcode
Copy link
Member Author

I like the way @abrown's #802 factored out the code for f32, f64, and v128 matching into separate functions rather than duplicating the logic for scalar and vector, so I've now incorporated that idea into this PR.

@sunfishcode sunfishcode merged commit ef2177e into bytecodealliance:master Jan 10, 2020
@sunfishcode sunfishcode deleted the update-submodules branch January 10, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants