cranelift/egraphs: more select/bitselect optimizations#6214
Open
jameysharp wants to merge 1 commit intobytecodealliance:mainfrom
Open
cranelift/egraphs: more select/bitselect optimizations#6214jameysharp wants to merge 1 commit intobytecodealliance:mainfrom
jameysharp wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
I've been thinking about the algebraic relationships between `bmask` and other instructions due to recent PRs, and wrote down a few of them here. These patterns don't seem to appear in any of the Sightglass `bz2`, `pulldown-cmark`, and `spidermonkey` benchmarks, as this PR has no effect on execution-time instructions retired for those benchmarks.
fitzgen
reviewed
May 9, 2023
Member
fitzgen
left a comment
There was a problem hiding this comment.
I think we want to be really careful about including select_spectre_guard optimizations in here. Might want to pull them out to their own file where we can argue why they are speculation safe.
Also these new optimization cases need tests.
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "cranelift", "isle"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been thinking about the algebraic relationships between
bmaskand other instructions due to recent PRs, and wrote down a few of them here.These patterns don't seem to appear in any of the Sightglass
bz2,pulldown-cmark, andspidermonkeybenchmarks, as this PR has no effect on execution-time instructions retired for those benchmarks.